Replace java.security.AccessController with org.opensearch.secure_sm.AccessController in sub projects with SocketAccess class by cwperks · Pull Request #19803 · opensearch-project/OpenSearch

cwperks · 2025-10-28T20:48:03Z

Description

Modules in this PR include:

crypto-kms plugin
repository-s3 plugin
repository-azure-classic plugin
repository-gcs plugin

Related Issues

Related to #18339

Check List

Functionality includes testing.
API changes companion pull request created, if applicable.
Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Craig Perkins <cwperx@amazon.com>

github-actions · 2025-10-28T22:52:25Z

❌ Gradle check result for daa1491: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Craig Perkins <cwperx@amazon.com>

github-actions · 2025-10-29T01:34:29Z

✅ Gradle check result for 003ec6e: SUCCESS

codecov · 2025-10-29T01:34:50Z

Codecov Report

❌ Patch coverage is 69.36937% with 34 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.19%. Comparing base (2f930dc) to head (f0c3d13).
⚠️ Report is 18 commits behind head on main.

Files with missing lines	Patch %	Lines
...ch/repositories/gcs/GoogleCloudStorageService.java	46.15%	6 Missing and 1 partial ⚠️
...org/opensearch/repositories/s3/S3AsyncService.java	64.70%	5 Missing and 1 partial ⚠️
...java/org/opensearch/repositories/s3/S3Service.java	66.66%	5 Missing and 1 partial ⚠️
.../opensearch/repositories/azure/AzureBlobStore.java	28.57%	5 Missing ⚠️
.../repositories/gcs/GoogleCloudStorageBlobStore.java	44.44%	5 Missing ⚠️
...rg/opensearch/crypto/kms/KmsMasterKeyProvider.java	0.00%	2 Missing ⚠️
...ensearch/crypto/kms/CredentialProviderFactory.java	0.00%	1 Missing ⚠️
...ain/java/org/opensearch/crypto/kms/KmsService.java	75.00%	1 Missing ⚠️
...ories/gcs/GoogleApplicationDefaultCredentials.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #19803      +/-   ##
============================================
- Coverage     73.24%   73.19%   -0.05%     
+ Complexity    71519    71500      -19     
============================================
  Files          5789     5785       -4     
  Lines        327121   327058      -63     
  Branches      47117    47116       -1     
============================================
- Hits         239591   239405     -186     
- Misses        68269    68403     +134     
+ Partials      19261    19250      -11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

...epository-gcs/src/main/java/org/opensearch/repositories/gcs/GoogleCloudStorageBlobStore.java

Signed-off-by: Craig Perkins <cwperx@amazon.com>

github-actions · 2025-11-07T19:35:41Z

✅ Gradle check result for ab90b6c: SUCCESS

Signed-off-by: Craig Perkins <cwperx@amazon.com>

…nSearch into remove-socket-access

github-actions · 2025-11-13T04:55:31Z

✅ Gradle check result for a76f0be: SUCCESS

cwperks · 2025-11-13T12:00:21Z

@sandeshkr419 I updated the AccessController interface to add a non-void method that throws a non-generic exception. That will clean this up a bit.

Signed-off-by: Craig Perkins <cwperx@amazon.com>

cwperks · 2025-11-18T20:31:00Z

@sandeshkr419 I fixed the conflicts. Can you re-review when you have some time?

github-actions · 2025-11-19T16:37:37Z

❌ Gradle check result for 283aba2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

…nSearch into remove-socket-access

Signed-off-by: Craig Perkins <cwperx@amazon.com>

github-actions · 2025-11-20T23:43:58Z

❌ Gradle check result for f0c3d13: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2025-11-25T21:47:42Z

❌ Gradle check result for f0c3d13: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2025-11-26T16:28:27Z

✅ Gradle check result for f0c3d13: SUCCESS

…AccessController in sub projects with SocketAccess class (opensearch-project#19803) * Replace AccessController in sub projects with SocketAccess class Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add to CHANGELOG Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add import Signed-off-by: Craig Perkins <cwperx@amazon.com> * Address review comments Signed-off-by: Craig Perkins <cwperx@amazon.com> * Address comments Signed-off-by: Craig Perkins <cwperx@amazon.com> * Wrap exception Signed-off-by: Craig Perkins <cwperx@amazon.com> * Wrap instead Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com>

Replace AccessController in sub projects with SocketAccess class

942be40

Signed-off-by: Craig Perkins <cwperx@amazon.com>

cwperks requested a review from a team as a code owner October 28, 2025 20:48

Add to CHANGELOG

daa1491

Signed-off-by: Craig Perkins <cwperx@amazon.com>

Add import

003ec6e

Signed-off-by: Craig Perkins <cwperx@amazon.com>

sandeshkr419 reviewed Oct 30, 2025

View reviewed changes

...epository-gcs/src/main/java/org/opensearch/repositories/gcs/GoogleCloudStorageBlobStore.java Outdated Show resolved Hide resolved

Merge branch 'main' into remove-socket-access

ab90b6c

Signed-off-by: Craig Perkins <cwperx@amazon.com>

sandeshkr419 mentioned this pull request Nov 12, 2025

[BUG] Deprecated sun.misc.Unsafe and AccessController warnings opensearch-project/search-relevance#306

Closed

cwperks added 4 commits November 12, 2025 22:21

Address review comments

1ea0948

Signed-off-by: Craig Perkins <cwperx@amazon.com>

Merge branch 'main' into remove-socket-access

b25c0b9

Address comments

1493796

Signed-off-by: Craig Perkins <cwperx@amazon.com>

Merge branch 'remove-socket-access' of https://github.com/cwperks/Ope…

a76f0be

…nSearch into remove-socket-access

Merge branch 'main' into remove-socket-access

283aba2

Signed-off-by: Craig Perkins <cwperx@amazon.com>

opensearch-ci-bot mentioned this pull request Nov 19, 2025

[AUTOCUT] Gradle Check Flaky Test Report for ConcurrentSeqNoVersioningIT #17271

Open

cwperks added 3 commits November 20, 2025 15:55

Merge branch 'remove-socket-access' of https://github.com/cwperks/Ope…

9fc4ca8

…nSearch into remove-socket-access

Wrap exception

0e1293e

Signed-off-by: Craig Perkins <cwperx@amazon.com>

Wrap instead

f0c3d13

Signed-off-by: Craig Perkins <cwperx@amazon.com>

sandeshkr419 approved these changes Nov 25, 2025

View reviewed changes

cwperks merged commit 3462571 into opensearch-project:main Nov 26, 2025
34 of 39 checks passed

This was referenced Nov 26, 2025

Implementing basic authentication for webhook auditlog sink opensearch-project/security#5792

Merged

Optimize getFieldFilter to only return a predicate when index has FLS restrictions for user opensearch-project/security#5777

Open

opensearch-ci-bot mentioned this pull request Nov 26, 2025

[AUTOCUT] Gradle Check Flaky Test Report for ConcurrentSnapshotsIT #20107

Open

BrewTestBot mentioned this pull request Dec 17, 2025

opensearch 3.4.0 Homebrew/homebrew-core#258986

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace java.security.AccessController with org.opensearch.secure_sm.AccessController in sub projects with SocketAccess class#19803

Replace java.security.AccessController with org.opensearch.secure_sm.AccessController in sub projects with SocketAccess class#19803
cwperks merged 12 commits intoopensearch-project:mainfrom
cwperks:remove-socket-access

cwperks commented Oct 28, 2025

Uh oh!

github-actions bot commented Oct 28, 2025

Uh oh!

github-actions bot commented Oct 29, 2025

Uh oh!

codecov bot commented Oct 29, 2025 •

edited

Loading

Uh oh!

Uh oh!

github-actions bot commented Nov 7, 2025

Uh oh!

github-actions bot commented Nov 13, 2025

Uh oh!

cwperks commented Nov 13, 2025

Uh oh!

cwperks commented Nov 18, 2025

Uh oh!

github-actions bot commented Nov 19, 2025

Uh oh!

github-actions bot commented Nov 20, 2025

Uh oh!

github-actions bot commented Nov 25, 2025

Uh oh!

github-actions bot commented Nov 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

cwperks commented Oct 28, 2025

Description

Related Issues

Check List

Uh oh!

github-actions bot commented Oct 28, 2025

Uh oh!

github-actions bot commented Oct 29, 2025

Uh oh!

codecov bot commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

github-actions bot commented Nov 7, 2025

Uh oh!

github-actions bot commented Nov 13, 2025

Uh oh!

cwperks commented Nov 13, 2025

Uh oh!

cwperks commented Nov 18, 2025

Uh oh!

github-actions bot commented Nov 19, 2025

Uh oh!

github-actions bot commented Nov 20, 2025

Uh oh!

github-actions bot commented Nov 25, 2025

Uh oh!

github-actions bot commented Nov 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Oct 29, 2025 •

edited

Loading